linux-kernel - Re: [PATCH 3.16 191/410] Input: mms114

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 08 Jun 2018 13:06:32 +0100
From:   Ben Hutchings <ben@...adent.org.uk>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:     lkml <linux-kernel@...r.kernel.org>,
        "3.8+" <stable@...r.kernel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Andi Shyti <andi.shyti@...sung.com>,
        Marcus Folkesson <marcus.folkesson@...il.com>
Subject: Re: [PATCH 3.16 191/410] Input: mms114 - fix license module
 information

On Thu, 2018-06-07 at 14:41 -0700, Dmitry Torokhov wrote:
> On Thu, Jun 7, 2018 at 7:05 AM, Ben Hutchings <ben@...adent.org.uk> wrote:
> > 3.16.57-rc1 review patch.  If anyone has any objections, please let me know.
> 
> Not a hard objection, but rather a curiosity: for this to be pulled
> into stable what user issue does this fix?

I start by selecting anything with a 'Cc: stable' or Fixes tag for a
commit that's in the stable branch.  If it applies cleanly I might not
look far beyond that.

This commit doesn't really meet the stable kernel rules, but it's
fixing documentation and is low risk so I'll keep it.

Ben.

> > 
> > ------------------
> > 
> > From: Andi Shyti <andi.shyti@...sung.com>
> > 
> > commit 498e7e7ed1fd72c275a682f0903c4a20cc538658 upstream.
> > 
> > The driver has been released with GNU Public License v2 as stated
> > in the header, but the module license information has been tagged
> > as "GPL" (GNU Public License v2 or later).
> > 
> > Fix the module license information so that it matches the one in
> > the header as "GPL v2".
> > 
> > Fixes: 07b8481d4aff ("Input: add MELFAS mms114 touchscreen driver")
> > Reported-by: Marcus Folkesson <marcus.folkesson@...il.com>
> > Signed-off-by: Andi Shyti <andi.shyti@...sung.com>
> > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>
> > Signed-off-by: Ben Hutchings <ben@...adent.org.uk>
> > ---
> >  drivers/input/touchscreen/mms114.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > --- a/drivers/input/touchscreen/mms114.c
> > +++ b/drivers/input/touchscreen/mms114.c
> > @@ -592,4 +592,4 @@ module_i2c_driver(mms114_driver);
> >  /* Module information */
> >  MODULE_AUTHOR("Joonyoung Shim <jy0922.shim@...sung.com>");
> >  MODULE_DESCRIPTION("MELFAS mms114 Touchscreen driver");
> > -MODULE_LICENSE("GPL");
> > +MODULE_LICENSE("GPL v2");
> > 
> 
> 
> 
-- 
Ben Hutchings
When in doubt, use brute force. - Ken Thompson


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)