linux-kernel - Re: [PATCH v6 8/8] staging: rtl8192e: remove unnecessary parentheses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 8 Jun 2018 14:01:29 +0100
From:   John Whitmore <arigead@...il.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     John Whitmore <johnfwhitmore@...il.com>,
        linux-kernel@...r.kernel.org, kstewart@...uxfoundation.org,
        devel@...verdev.osuosl.org, gregkh@...uxfoundation.org,
        colin.king@...onical.com, tglx@...utronix.de
Subject: Re: [PATCH v6 8/8] staging: rtl8192e: remove unnecessary parentheses
 - Coding Style

On Fri, Jun 08, 2018 at 03:18:51PM +0300, Dan Carpenter wrote:
> On Wed, Jun 06, 2018 at 12:40:03PM +0100, John Whitmore wrote:
> > @@ -1072,10 +1072,10 @@ void HTInitializeHTInfo(struct ieee80211_device *ieee)
> >  	pHTInfo->CurrentAMPDUFactor = pHTInfo->AMPDU_Factor;
> >  
> >  	// Initialize all of the parameters related to 11n
> > -	memset((void *)(&(pHTInfo->SelfHTCap)), 0, sizeof(pHTInfo->SelfHTCap));
> > -	memset((void *)(&(pHTInfo->SelfHTInfo)), 0, sizeof(pHTInfo->SelfHTInfo));
> > -	memset((void *)(&(pHTInfo->PeerHTCapBuf)), 0, sizeof(pHTInfo->PeerHTCapBuf));
> > -	memset((void *)(&(pHTInfo->PeerHTInfoBuf)), 0, sizeof(pHTInfo->PeerHTInfoBuf));
> > +	memset((void *)(&pHTInfo->SelfHTCap), 0, sizeof(pHTInfo->SelfHTCap));
> > +	memset((void *)(&pHTInfo->SelfHTInfo), 0, sizeof(pHTInfo->SelfHTInfo));
> > +	memset((void *)(&pHTInfo->PeerHTCapBuf), 0, sizeof(pHTInfo->PeerHTCapBuf));
> > +	memset((void *)(&pHTInfo->PeerHTInfoBuf), 0, sizeof(pHTInfo->PeerHTInfoBuf));
> 
> You should write these like so:
> 
> 	memset(&pHTInfo->PeerHTInfoBuf, 0, sizeof(pHTInfo->PeerHTInfoBuf));
> 
> The first 7 patches look fine, but can you resend this last one?
> 
> regards,
> dan carpenter
> 

I can certainly try. I've bumped it to v7 so here goes...

John