linux-kernel - Re: [PATCH 06/20] coresight: Handle errors in finding input/output ports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 8 Jun 2018 14:24:28 -0600
From:   Mathieu Poirier <mathieu.poirier@...aro.org>
To:     Suzuki K Poulose <suzuki.poulose@....com>
Cc:     linux-arm-kernel@...ts.infradead.org, robh@...nel.org,
        frowand.list@...il.com, mark.rutland@....com, sudeep.holla@....com,
        arm@...nel.org, linux-kernel@...r.kernel.org, matt.sealey@....com,
        john.horley@....com, charles.garcia-tobin@....com,
        coresight@...ts.linaro.org, devicetree@...r.kernel.org,
        mike.leach@...aro.org
Subject: Re: [PATCH 06/20] coresight: Handle errors in finding input/output
 ports

On Tue, Jun 05, 2018 at 10:43:17PM +0100, Suzuki K Poulose wrote:
> If we fail to find the input / output port for a LINK component
> while enabling a path, we should fail gracefully rather than
> assuming port "0".
> 
> Cc: Mathieu Poirier <mathieu.poirier@...aro.org>
> Signed-off-by: Suzuki K Poulose <suzuki.poulose@....com>
> ---
>  drivers/hwtracing/coresight/coresight.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/hwtracing/coresight/coresight.c b/drivers/hwtracing/coresight/coresight.c
> index 69e9136..3c1c058 100644
> --- a/drivers/hwtracing/coresight/coresight.c
> +++ b/drivers/hwtracing/coresight/coresight.c
> @@ -107,7 +107,7 @@ static int coresight_find_link_inport(struct coresight_device *csdev,
>  	dev_err(&csdev->dev, "couldn't find inport, parent: %s, child: %s\n",
>  		dev_name(&parent->dev), dev_name(&csdev->dev));
>  
> -	return 0;
> +	return -ENODEV;
>  }
>  
>  static int coresight_find_link_outport(struct coresight_device *csdev,
> @@ -125,7 +125,7 @@ static int coresight_find_link_outport(struct coresight_device *csdev,
>  	dev_err(&csdev->dev, "couldn't find outport, parent: %s, child: %s\n",
>  		dev_name(&csdev->dev), dev_name(&child->dev));
>  
> -	return 0;
> +	return -ENODEV;
>  }
>  
>  static int coresight_enable_sink(struct coresight_device *csdev, u32 mode)
> @@ -178,6 +178,9 @@ static int coresight_enable_link(struct coresight_device *csdev,
>  	else
>  		refport = 0;
>  
> +	if (refport < 0)
> +		return refport;
> +
>  	if (atomic_inc_return(&csdev->refcnt[refport]) == 1) {
>  		if (link_ops(csdev)->enable) {
>  			ret = link_ops(csdev)->enable(csdev, inport, outport);

Queued for the next rc - no need to resend.

Thanks,
Mathieu

> -- 
> 2.7.4
>