lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 11 Jun 2018 18:03:33 -0700 From: Ray Jui <ray.jui@...adcom.com> To: Florian Fainelli <f.fainelli@...il.com>, Lorenzo Pieralisi <lorenzo.pieralisi@....com>, Bjorn Helgaas <bhelgaas@...gle.com>, Rob Herring <robh+dt@...nel.org>, Mark Rutland <mark.rutland@....com> Cc: linux-kernel@...r.kernel.org, bcm-kernel-feedback-list@...adcom.com, linux-pci@...r.kernel.org, devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org Subject: Re: [PATCH 3/6] arm: dts: Change PCIe INTx mapping for Cygnus On 6/11/2018 5:55 PM, Florian Fainelli wrote: > On June 11, 2018 5:27:20 PM PDT, Ray Jui <ray.jui@...adcom.com> wrote: >> >> >> On 6/11/2018 3:36 PM, Florian Fainelli wrote: >>> On 05/29/2018 02:58 PM, Ray Jui wrote: >>>> Change the PCIe INTx mapping to model the 4 INTx interrupts in the >>>> IRQ domain of the iProc PCIe controller itself >>>> >>>> Signed-off-by: Ray Jui <ray.jui@...adcom.com> >>>> --- >>>> arch/arm/boot/dts/bcm-cygnus.dtsi | 18 ++++++++++++++---- >>>> 1 file changed, 14 insertions(+), 4 deletions(-) >>>> >>>> diff --git a/arch/arm/boot/dts/bcm-cygnus.dtsi >> b/arch/arm/boot/dts/bcm-cygnus.dtsi >>>> index 699fdf9..6de21ef 100644 >>>> --- a/arch/arm/boot/dts/bcm-cygnus.dtsi >>>> +++ b/arch/arm/boot/dts/bcm-cygnus.dtsi >>>> @@ -254,9 +254,14 @@ >>>> compatible = "brcm,iproc-pcie"; >>>> reg = <0x18012000 0x1000>; >>>> >>>> + interrupt-controller; >>>> #interrupt-cells = <1>; >>>> - interrupt-map-mask = <0 0 0 0>; >>>> - interrupt-map = <0 0 0 0 &gic GIC_SPI 100 IRQ_TYPE_NONE>; >>>> + interrupt-map-mask = <0 0 0 7>; >>>> + interrupt-map = <0 0 0 1 &pcie0 1>, >>>> + <0 0 0 2 &pcie0 2>, >>>> + <0 0 0 3 &pcie0 3>, >>>> + <0 0 0 4 &pcie0 4>; >>>> + interrupts = <GIC_SPI 100 IRQ_TYPE_NONE>; >>> >>> You would want to fix those IRQ_TYPE_NONE values as well because >> since >>> commit 83a86fbb5b56b5eed8a476cc3fe214077d7c4f49 ("irqchip/gic: Loudly >>> complain about the use of IRQ_TYPE_NONE") this is going to create >> some >>> nice warnings on boot. >>> >>> I am about to send fixes for NSP and HR2 since that's what I have >> access >>> to at the moment, but it would be good if you could send updates to >> the >>> Cygnus and NS2 DTS files? >>> >>> Thanks >>> >> >> Okay. Thanks for letting me know. How do you want this to be done for >> Cygnus and NS2? >> >> I guess I should have the fix patches to DTS done and sent out first, >> and then rebase this INTx patch series against the patches with the >> fix. >> >> Does that make sense to you? > > Yes it does. As soon as v4.18-rc1 is tagged I will send the Device Tree fixes pull request, if I can have yours for Cygnus and NS2 in the next few days I could lump those together. Then we can either base your changes off v4.18-rc2 or a later tag that already has the DTS fixes. > Okay that sounds good. I'll try to get those fixes out for you within the next few days. Thanks! Ray
Powered by blists - more mailing lists