linux-kernel - Re: [PATCH 2/2] lightnvm: pblk: enable line minor version detection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 12 Jun 2018 14:37:41 +0000
From:   Javier Gonzalez <javier@...xlabs.com>
To:     Matias Bjørling <mb@...htnvm.io>
CC:     "Konopko, Igor J" <igor.j.konopko@...el.com>,
        "marcin.dziegielewski@...el.com" <marcin.dziegielewski@...el.com>,
        "Hans Holmberg" <hans.holmberg@...xlabs.com>,
        "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] lightnvm: pblk: enable line minor version detection

> On 12 Jun 2018, at 04.29, Matias Bjørling <mb@...htnvm.io> wrote:
> 
> When recovering a line, an extra check was added when debugging was
> active, such that minor version where also checked. Unfortunately,
> this used the ifdef NVM_DEBUG, which is not correct.
> 
> Instead use the proper DEBUG def, and now that it compiles, also fix
> the variable.
> 
> Signed-off-by: Matias Bjørling <mb@...htnvm.io>
> Fixes: d0ab0b1ab991f ("lightnvm: pblk: check data lines version on recovery")
> ---
> drivers/lightnvm/pblk-recovery.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/lightnvm/pblk-recovery.c b/drivers/lightnvm/pblk-recovery.c
> index 598342833d0d..b1a91cb3ca4d 100644
> --- a/drivers/lightnvm/pblk-recovery.c
> +++ b/drivers/lightnvm/pblk-recovery.c
> @@ -742,9 +742,10 @@ static int pblk_recov_check_line_version(struct pblk *pblk,
> 		return 1;
> 	}
> 
> -#ifdef NVM_DEBUG
> +#ifdef CONFIG_NVM_PBLK_DEBUG
> 	if (header->version_minor > EMETA_VERSION_MINOR)
> -		pr_info("pblk: newer line minor version found: %d\n", line_v);
> +		pr_info("pblk: newer line minor version found: %d\n",
> +				header->version_minor);
> #endif
> 
> 	return 0;
> --
> 2.11.0

Good catch.

Reviewed-by: Javier González <javier@...xlabs.com>


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)