linux-kernel - Re: [PATCH] Fixed an indentation error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 13 Jun 2018 05:32:03 -0700
From:   Joe Perches <joe@...ches.com>
To:     Parth Y Shah <sparth1292@...il.com>, balbi@...nel.org,
        gregkh@...uxfoundation.org, linux-usb@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Fixed an indentation error

On Wed, 2018-06-13 at 17:55 +0530, Parth Y Shah wrote:
> Signed-off-by: Parth Y Shah <sparth1292@...il.com>

-ENOCHANGELOG

Why do you think this is an error?
Why is the dev_dbg useful at all?

> diff --git a/drivers/usb/gadget/configfs.c b/drivers/usb/gadget/configfs.c
[]
> @@ -1217,8 +1217,8 @@ static void purge_configs_funcs(struct gadget_info *gi)
>  			list_move_tail(&f->list, &cfg->func_list);
>  			if (f->unbind) {
>  				dev_dbg(&gi->cdev.gadget->dev,
> -				         "unbind function '%s'/%p\n",
> -				         f->name, f);
> +						"unbind function '%s'/%p\n",
> +						f->name, f);
>  				f->unbind(c, f);
>  			}
>  		}