lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 13 Jun 2018 13:09:06 +0000 From: Bart Van Assche <Bart.VanAssche@....com> To: "jthumshirn@...e.de" <jthumshirn@...e.de>, "martin.petersen@...cle.com" <martin.petersen@...cle.com> CC: "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH v2 2/3] scsi: check for equality of result byte values On Wed, 2018-06-13 at 09:53 +0200, Johannes Thumshirn wrote: > if ((cmd->result == (DID_OK << 16) > - || status_byte(cmd->result) & > - CHECK_CONDITION)) { > + || status_byte(cmd->result) == CHECK_CONDITION)) { A minor comment: the preferred coding style is to place "||" at the end of the previous line. > - if ((driver_byte(the_result) & DRIVER_SENSE) == 0) { > + if (driver_byte(the_result) == DRIVER_SENSE) { This change looks wrong to me. Bart.
Powered by blists - more mailing lists