linux-kernel - Re: [PATCH v4 3/5] sched/core: Streamlining calls to task_rq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 14 Jun 2018 09:42:42 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Juri Lelli <juri.lelli@...hat.com>
Cc:     peterz@...radead.org, mingo@...hat.com,
        linux-kernel@...r.kernel.org, luca.abeni@...tannapisa.it,
        claudio@...dence.eu.com, tommaso.cucinotta@...tannapisa.it,
        bristot@...hat.com, mathieu.poirier@...aro.org, lizefan@...wei.com,
        cgroups@...r.kernel.org
Subject: Re: [PATCH v4 3/5] sched/core: Streamlining calls to
 task_rq_unlock()

On Wed, 13 Jun 2018 14:17:09 +0200
Juri Lelli <juri.lelli@...hat.com> wrote:

> From: Mathieu Poirier <mathieu.poirier@...aro.org>
> 
> Calls to task_rq_unlock() are done several times in function
> __sched_setscheduler().  This is fine when only the rq lock needs to be
> handled but not so much when other locks come into play.
> 
> This patch streamlines the release of the rq lock so that only one
> location need to be modified when dealing with more than one lock.
> 
> No change of functionality is introduced by this patch.
> 
> Signed-off-by: Mathieu Poirier <mathieu.poirier@...aro.org>

Reviewed-by: Steven Rostedt (VMware) <rostedt@...dmis.org>

-- Steve