linux-kernel - Re: [PATCH 3/9] staging: rtl8192u: Truncate block comments to 80 character length

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 19 Jun 2018 23:09:30 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     John Whitmore <johnfwhitmore@...il.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        devel@...verdev.osuosl.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/9] staging: rtl8192u: Truncate block comments to 80
 character length - Style

On Tue, Jun 19, 2018 at 10:55 PM, John Whitmore <johnfwhitmore@...il.com> wrote:
> Where possible truncation of block comments to the 80 character length
> prefered by the coding style.

Is it somehow automated?!

>         /*
> -        * 8190 only, Realtek proprietary aggregation mode
> -        * Set MPDUDensity=2,   1: Set MPDUDensity=2(32k)  for Realtek AP and set MPDUDensity=0(8k) for others
> +        * 8190 only, Realtek proprietary aggregation mode Set MPDUDensity=2,
> +        * 1: Set MPDUDensity=2(32k) for Realtek AP
> +        * and set MPDUDensity=0(8k) for others
>          */

This is just an example how it should NOT be done.
The original looks better than the result in terms of understanding.

Had you (re-)read the result?

-- 
With Best Regards,
Andy Shevchenko