linux-kernel - Re: [PATCH] MIPS: Octeon: assign bool true/false not 1/0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 19 Jun 2018 16:28:28 -0700
From:   Paul Burton <paul.burton@...s.com>
To:     Nicholas Mc Guire <hofrat@...dl.org>
CC:     Ralf Baechle <ralf@...ux-mips.org>,
        James Hogan <jhogan@...nel.org>,
        David Daney <david.daney@...ium.com>,
        "Steven J. Hill" <Steven.Hill@...ium.com>,
        Joe Perches <joe@...ches.com>,
        Colin Ian King <colin.king@...onical.com>,
        <linux-mips@...ux-mips.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] MIPS: Octeon: assign bool true/false not 1/0

Hi Nicholas,

On Sat, Jun 16, 2018 at 09:26:32AM +0200, Nicholas Mc Guire wrote:
> Booleans should be assigned true/false not 1/0 as comparison is not needed
> 
> Signed-off-by: Nicholas Mc Guire <hofrat@...dl.org>
> ---
> 
> Problem located by scripts/coccinelle/misc/boolinit.cocci
>   ./arch/mips/cavium-octeon/octeon-irq.c:817:3-13:
>   WARNING: Assignment of bool to 0/1
> 
> Patch was compile tested with: cavium_octeon_defconfig
> (with a number of sparse warnings - not related to the proposed change)
> 
> Patch is against 4.17.0 (localversion-next is next-20180614)
> 
>  arch/mips/cavium-octeon/octeon-irq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks, applied to mips-next for 4.19.

Paul