linux-kernel - Re: [PATCH 12/13] selinux: Cleanup printk logging in avc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 19 Jun 2018 13:48:38 -0400
From:   Paul Moore <paul@...l-moore.com>
To:     peter.enderborg@...y.com
Cc:     Stephen Smalley <sds@...ho.nsa.gov>,
        Eric Paris <eparis@...isplace.org>,
        James Morris <jmorris@...ei.org>, danielj@...lanox.com,
        dledford@...hat.com, selinux@...ho.nsa.gov,
        linux-security-module@...r.kernel.org,
        linux-kernel@...r.kernel.org, serge@...lyn.com
Subject: Re: [PATCH 12/13] selinux: Cleanup printk logging in avc

On Tue, Jun 12, 2018 at 4:09 AM Peter Enderborg
<peter.enderborg@...y.com> wrote:
>
> Replace printk with pr_* to avoid checkpatch warnings.
>
> Signed-off-by: Peter Enderborg <peter.enderborg@...y.com>
> ---
>  security/selinux/avc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Merged, thanks.

> diff --git a/security/selinux/avc.c b/security/selinux/avc.c
> index f3aedf077509..635e5c1e3e48 100644
> --- a/security/selinux/avc.c
> +++ b/security/selinux/avc.c
> @@ -650,7 +650,7 @@ static int avc_latest_notif_update(struct selinux_avc *avc,
>         spin_lock_irqsave(&notif_lock, flag);
>         if (is_insert) {
>                 if (seqno < avc->avc_cache.latest_notif) {
> -                       printk(KERN_WARNING "SELinux: avc:  seqno %d < latest_notif %d\n",
> +                       pr_warn("SELinux: avc:  seqno %d < latest_notif %d\n",
>                                seqno, avc->avc_cache.latest_notif);
>                         ret = -EAGAIN;
>                 }
> --
> 2.15.1
>


-- 
paul moore
www.paul-moore.com