linux-kernel - Re: [PATCH 1/3] reiserfs: remove unused j

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 20 Jun 2018 10:21:18 +0200
From:   Jan Kara <jack@...e.cz>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Al Viro <viro@...iv.linux.org.uk>,
        Andrew Morton <akpm@...ux-foundation.org>,
        y2038@...ts.linaro.org, Jan Kara <jack@...e.cz>,
        Thomas Gleixner <tglx@...utronix.de>,
        reiserfs-devel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] reiserfs: remove unused j_timestamp

On Tue 19-06-18 17:43:13, Arnd Bergmann wrote:
> This uses the deprecated time_t type but is write-only, so we
> can just remove it.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Looks good to me. You can add:

Reviewed-by: Jan Kara <jack@...e.cz>

								Honza

> ---
>  fs/reiserfs/journal.c  | 1 -
>  fs/reiserfs/reiserfs.h | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/fs/reiserfs/journal.c b/fs/reiserfs/journal.c
> index 52eb5d293a34..1e7f733b2a12 100644
> --- a/fs/reiserfs/journal.c
> +++ b/fs/reiserfs/journal.c
> @@ -4110,7 +4110,6 @@ static int do_journal_end(struct reiserfs_transaction_handle *th, int flags)
>  
>  	atomic_set(&jl->j_older_commits_done, 0);
>  	jl->j_trans_id = journal->j_trans_id;
> -	jl->j_timestamp = journal->j_trans_start_time;
>  	jl->j_commit_bh = c_bh;
>  	jl->j_start = journal->j_start;
>  	jl->j_len = journal->j_len;
> diff --git a/fs/reiserfs/reiserfs.h b/fs/reiserfs/reiserfs.h
> index ae4811fecc1f..1536ebbaf6ab 100644
> --- a/fs/reiserfs/reiserfs.h
> +++ b/fs/reiserfs/reiserfs.h
> @@ -271,7 +271,6 @@ struct reiserfs_journal_list {
>  
>  	struct mutex j_commit_mutex;
>  	unsigned int j_trans_id;
> -	time_t j_timestamp;
>  	struct reiserfs_list_bitmap *j_list_bitmap;
>  	struct buffer_head *j_commit_bh;	/* commit buffer head */
>  	struct reiserfs_journal_cnode *j_realblock;
> -- 
> 2.9.0
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR