linux-kernel - Re: [PATCH] drm/bridge/sii8620: fix display of packed pixel modes in MHL2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 21 Jun 2018 12:53:24 +0200
From:   Andrzej Hajda <a.hajda@...sung.com>
To:     Maciej Purski <m.purski@...sung.com>,
        dri-devel@...ts.freedesktop.org
Cc:     Archit Taneja <architt@...eaurora.org>,
        Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
        David Airlie <airlied@...ux.ie>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/bridge/sii8620: fix display of packed pixel modes
 in MHL2

On 23.01.2018 12:17, Maciej Purski wrote:
> Currently packed pixel modes in MHL2 can't be displayed. The device
> automatically recognizes output format, so setting format other than
> RGB causes failure. Fix it by writing proper values to registers.
>
> Tested on MHL1 and MHL2 using various vendors' dongles both in
> DVI and HDMI mode.
>
> Signed-off-by: Maciej Purski <m.purski@...sung.com>

Another missed one, queued to drm-misc-fixes.

--
Regards
Andrzej

> ---
>  drivers/gpu/drm/bridge/sil-sii8620.c | 17 +----------------
>  1 file changed, 1 insertion(+), 16 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/sil-sii8620.c b/drivers/gpu/drm/bridge/sil-sii8620.c
> index 1718c2e..e13708d 100644
> --- a/drivers/gpu/drm/bridge/sil-sii8620.c
> +++ b/drivers/gpu/drm/bridge/sil-sii8620.c
> @@ -1005,20 +1005,11 @@ static void sii8620_stop_video(struct sii8620 *ctx)
>  
>  static void sii8620_set_format(struct sii8620 *ctx)
>  {
> -	u8 out_fmt;
> -
>  	if (sii8620_is_mhl3(ctx)) {
>  		sii8620_setbits(ctx, REG_M3_P0CTRL,
>  				BIT_M3_P0CTRL_MHL3_P0_PIXEL_MODE_PACKED,
>  				ctx->use_packed_pixel ? ~0 : 0);
>  	} else {
> -		if (ctx->use_packed_pixel)
> -			sii8620_write_seq_static(ctx,
> -				REG_VID_MODE, BIT_VID_MODE_M1080P,
> -				REG_MHL_TOP_CTL, BIT_MHL_TOP_CTL_MHL_PP_SEL | 1,
> -				REG_MHLTX_CTL6, 0x60
> -			);
> -		else
>  			sii8620_write_seq_static(ctx,
>  				REG_VID_MODE, 0,
>  				REG_MHL_TOP_CTL, 1,
> @@ -1026,15 +1017,9 @@ static void sii8620_set_format(struct sii8620 *ctx)
>  			);
>  	}
>  
> -	if (ctx->use_packed_pixel)
> -		out_fmt = VAL_TPI_FORMAT(YCBCR422, FULL) |
> -			BIT_TPI_OUTPUT_CSCMODE709;
> -	else
> -		out_fmt = VAL_TPI_FORMAT(RGB, FULL);
> -
>  	sii8620_write_seq(ctx,
>  		REG_TPI_INPUT, VAL_TPI_FORMAT(RGB, FULL),
> -		REG_TPI_OUTPUT, out_fmt,
> +		REG_TPI_OUTPUT, VAL_TPI_FORMAT(RGB, FULL),
>  	);
>  }
>