linux-kernel - Re: [PATCH 1/2] microblaze: remove unecessary of_platform_bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 21 Jun 2018 13:27:19 +0200
From:   Michal Simek <monstr@...str.eu>
To:     Rob Herring <robh@...nel.org>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] microblaze: remove unecessary of_platform_bus_probe
 call

On 19.6.2018 23:36, Rob Herring wrote:
> The call to of_platform_bus_probe has no effect because the DT core
> already probes default buses like "simple-bus" before this call.
> Michal Simek said 'xlnx,compound' hasn't been used in a long time, so
> that match entry isn't needed.
> 
> Cc: Michal Simek <monstr@...str.eu>
> Signed-off-by: Rob Herring <robh@...nel.org>
> ---
>  arch/microblaze/kernel/platform.c | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/arch/microblaze/kernel/platform.c b/arch/microblaze/kernel/platform.c
> index 2540d60610d9..b9a414552d9b 100644
> --- a/arch/microblaze/kernel/platform.c
> +++ b/arch/microblaze/kernel/platform.c
> @@ -14,15 +14,8 @@
>  #include <linux/of_platform.h>
>  #include <asm/setup.h>
>  
> -static struct of_device_id xilinx_of_bus_ids[] __initdata = {
> -	{ .compatible = "simple-bus", },
> -	{ .compatible = "xlnx,compound", },
> -	{}
> -};
> -
>  static int __init microblaze_device_probe(void)
>  {
> -	of_platform_bus_probe(NULL, xilinx_of_bus_ids, NULL);
>  	of_platform_reset_gpio_probe();
>  	return 0;
>  }
> 

Applied.

Thanks,
Michal


-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP SoCs




Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)