linux-kernel - Re: [PATCH] x86/mce: Do not overwrite MCi_STATUS in mce_no_way

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 21 Jun 2018 22:10:56 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     "Luck, Tony" <tony.luck@...el.com>
Cc:     LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86/mce: Do not overwrite MCi_STATUS in mce_no_way_out()

On Thu, Jun 21, 2018 at 01:00:03PM -0700, Luck, Tony wrote:
> On Thu, Jun 21, 2018 at 09:17:11PM +0200, Borislav Petkov wrote:
> > On Thu, Jun 21, 2018 at 11:18:09AM -0700, Luck, Tony wrote:
> > > Counter proposal.  We don't need the temp mci_status because we exit the
> > > loop early.  Nor the "ret" variable.
> > > 
> > > 
> > > How does this look?
> > 
> > Yap, better. I'll test it later or tomorrow:
> > 
> 
> Or even better. Just adds the "mce_read_aux()" to check ADDRV and MISCV
> and populate more of the struct mce.

I thought about it but decided to leave it for another day. But ok, it
is a one more line and I guess it is ok to have it in the same patch,
I'll add it.

Thx.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.