linux-kernel - Re: [PATCH] ASoC: uniphier: remove redundant check of PLL ID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 21 Jun 2018 11:54:43 +0900
From:   "Katsuhiro Suzuki" <suzuki.katsuhiro@...ionext.com>
To:     "Mark Brown" <broonie@...nel.org>, <alsa-devel@...a-project.org>
Cc:     "Masami Hiramatsu" <masami.hiramatsu@...aro.org>,
        "Jassi Brar" <jaswinder.singh@...aro.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ASoC: uniphier: remove redundant check of PLL ID

Hello,

I got mistake (forget to remove unused variable).
I'll send v2. Sorry for confusing.

Regards,
--
Katsuhiro Suzuki


> -----Original Message-----
> From: Katsuhiro Suzuki <suzuki.katsuhiro@...ionext.com>
> Sent: Thursday, June 21, 2018 11:44 AM
> To: Mark Brown <broonie@...nel.org>; alsa-devel@...a-project.org
> Cc: Masami Hiramatsu <masami.hiramatsu@...aro.org>; Jassi Brar
> <jaswinder.singh@...aro.org>; linux-arm-kernel@...ts.infradead.org;
> linux-kernel@...r.kernel.org; Suzuki, Katsuhiro/鈴木 勝博
> <suzuki.katsuhiro@...ionext.com>
> Subject: [PATCH] ASoC: uniphier: remove redundant check of PLL ID
> 
> This patch removes redudant check of PLL ID. struct uniphier_aio_pll
> enable member has already been checked at is_valid_pll().
> 
> Signed-off-by: Katsuhiro Suzuki <suzuki.katsuhiro@...ionext.com>
> ---
>  sound/soc/uniphier/aio-cpu.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/sound/soc/uniphier/aio-cpu.c b/sound/soc/uniphier/aio-cpu.c
> index 2d9b7dde2ffa..cfe69ab44b63 100644
> --- a/sound/soc/uniphier/aio-cpu.c
> +++ b/sound/soc/uniphier/aio-cpu.c
> @@ -224,10 +224,6 @@ static int uniphier_aio_set_pll(struct snd_soc_dai *dai,
int
> pll_id,
> 
>  	if (!is_valid_pll(aio->chip, pll_id))
>  		return -EINVAL;
> -	if (!aio->chip->plls[pll_id].enable) {
> -		dev_err(dev, "PLL(%d) is not implemented\n", pll_id);
> -		return -ENOTSUPP;
> -	}
> 
>  	ret = aio_chip_set_pll(aio->chip, pll_id, freq_out);
>  	if (ret < 0)
> --
> 2.17.1