linux-kernel - Re: [PATCH v1 1/1] VSOCK: fix loopback on big-endian systems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 22 Jun 2018 09:34:44 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     imbrenda@...ux.vnet.ibm.com
Cc:     stefanha@...hat.com, jhansen@...are.com, cavery@...hat.com,
        borntraeger@...ibm.com, fiuczy@...ux.ibm.com,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH v1 1/1] VSOCK: fix loopback on big-endian systems

From: Claudio Imbrenda <imbrenda@...ux.vnet.ibm.com>
Date: Wed, 20 Jun 2018 15:51:51 +0200

> The dst_cid and src_cid are 64 bits, therefore 64 bit accessors should be
> used, and in fact in virtio_transport_common.c only 64 bit accessors are
> used. Using 32 bit accessors for 64 bit values breaks big endian systems.
> 
> This patch fixes a wrong use of le32_to_cpu in virtio_transport_send_pkt.
> 
> Fixes: b9116823189e85ccf384 ("VSOCK: add loopback to virtio_transport")
> 
> Signed-off-by: Claudio Imbrenda <imbrenda@...ux.vnet.ibm.com>

Applied and queued up for -stable, thank you.