linux-kernel - Re: [PATCH v6 3/3] x86: paravirt: make native_save

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 22 Jun 2018 04:24:02 +0200
From:   Ingo Molnar <mingo@...nel.org>
To:     Nick Desaulniers <ndesaulniers@...gle.com>
Cc:     mingo@...hat.com, tglx@...utronix.de, akpm@...ux-foundation.org,
        hpa@...or.com, linux-efi@...r.kernel.org,
        linux-kernel@...r.kernel.org, x86@...nel.org,
        virtualization@...ts.linux-foundation.org, astrachan@...gle.com,
        manojgupta@...gle.com, ghackmann@...gle.com, sedat.dilek@...il.com,
        tstellar@...hat.com, keescook@...gle.com,
        yamada.masahiro@...ionext.com, michal.lkml@...kovi.net,
        linux-kbuild@...r.kernel.org, geert@...ux-m68k.org,
        will.deacon@....com, mawilcox@...rosoft.com, arnd@...db.de,
        rientjes@...gle.com, acme@...hat.com, pombredanne@...b.com,
        aryabinin@...tuozzo.com, kstewart@...uxfoundation.org,
        boris.ostrovsky@...cle.com, jan.kiszka@...mens.com,
        rostedt@...dmis.org, kirill.shutemov@...ux.intel.com,
        ard.biesheuvel@...aro.org, akataria@...are.com,
        brijesh.singh@....com, caoj.fnst@...fujitsu.com,
        gregkh@...uxfoundation.org, jarkko.sakkinen@...ux.intel.com,
        jgross@...e.com, jpoimboe@...hat.com, mka@...omium.org,
        thomas.lendacky@....com, tweek@...gle.com, mjg59@...gle.com,
        joe@...ches.com, andrea.parri@...rulasolutions.com
Subject: Re: [PATCH v6 3/3] x86: paravirt: make native_save_fl extern inline


* Nick Desaulniers <ndesaulniers@...gle.com> wrote:

> native_save_fl() is marked static inline, but by using it as
> a function pointer in arch/x86/kernel/paravirt.c, it MUST be outlined.

> --- a/arch/x86/include/asm/irqflags.h
> +++ b/arch/x86/include/asm/irqflags.h
> @@ -13,7 +13,7 @@
>   * Interrupt control:
>   */
>  
> -static inline unsigned long native_save_fl(void)
> +extern inline unsigned long native_save_fl(void)
>  {
>  	unsigned long flags;
>  

What's the code generation effect of this on say a defconfig kernel vmlinux with 
paravirt enabled?

Thanks,

	Ingo