linux-kernel - Re: [PATCH v2 3/8] staging: rtl8192u: User memset to initialize memory, instead of loop.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 24 Jun 2018 15:32:49 +0100
From:   John Whitmore <arigead@...il.com>
To:     Joe Perches <joe@...ches.com>
Cc:     John Whitmore <johnfwhitmore@...il.com>,
        linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org,
        gregkh@...uxfoundation.org
Subject: Re: [PATCH v2 3/8] staging: rtl8192u: User memset to initialize
 memory, instead of loop.

On Sun, Jun 24, 2018 at 07:26:41AM -0700, Joe Perches wrote:
> On Sun, 2018-06-24 at 10:57 +0100, John Whitmore wrote:
> > Replaced memory initialising loop with memset, as suggested by Andy Shevchenko
> []
> > diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
> []
> > @@ -742,8 +742,6 @@ void HTConstructRT2RTAggElement(struct ieee80211_device *ieee, u8 *posRT2RTAgg,
> >   */
> >  static u8 HT_PickMCSRate(struct ieee80211_device *ieee, u8 *pOperateMCS)
> >  {
> > -	u8					i;
> > -
> >  	if (!pOperateMCS) {
> >  		IEEE80211_DEBUG(IEEE80211_DL_ERR, "pOperateMCS can't be null in HT_PickMCSRate()\n");
> >  		return false;
> > @@ -756,8 +754,7 @@ static u8 HT_PickMCSRate(struct ieee80211_device *ieee, u8 *pOperateMCS)
> >  		//legacy rate routine handled at selectedrate
> >  
> >  		//no MCS rate
> > -		for (i = 0; i <= 15; i++)
> > -			pOperateMCS[i] = 0;
> > +		memset(pOperateMCS, 0, 15);
> 
> Not the same code.
> 
> Loop is <= 15, so memset should use 16
> 

Arragghhhh! Thank you and thank you for spotting that. I'll reissue again. I
should have been more careful. Sorry.