linux-kernel - Re: [PATCH v7 4/6] mtd: rawnand: add NVIDIA Tegra NAND Flash controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 24 Jun 2018 23:16:30 +0200
From:   Stefan Agner <stefan@...er.ch>
To:     Boris Brezillon <boris.brezillon@...tlin.com>
Cc:     dwmw2@...radead.org, computersforpeace@...il.com,
        marek.vasut@...il.com, robh+dt@...nel.org, mark.rutland@....com,
        thierry.reding@...il.com, benjamin.lindqvist@...ian.se,
        pgaikwad@...dia.com, dev@...xeye.de, mirza.krak@...il.com,
        richard@....at, pdeschrijver@...dia.com,
        linux-kernel@...r.kernel.org, krzk@...nel.org,
        jonathanh@...dia.com, devicetree@...r.kernel.org,
        linux-mtd@...ts.infradead.org, marcel@...wiler.com,
        miquel.raynal@...tlin.com, linux-tegra@...r.kernel.org,
        digetx@...il.com, gaireg@...reg.de
Subject: Re: [PATCH v7 4/6] mtd: rawnand: add NVIDIA Tegra NAND Flash
 controller driver

On 24.06.2018 21:50, Boris Brezillon wrote:
> On Sun, 24 Jun 2018 21:22:28 +0200
> Stefan Agner <stefan@...er.ch> wrote:
> 
>> +
>> +static int tegra_nand_remove(struct platform_device *pdev)
>> +{
>> +	struct tegra_nand_controller *ctrl = platform_get_drvdata(pdev);
>> +
>> +	nand_release(nand_to_mtd(ctrl->chip));
> 
> I still see nand_release() being used here. As I said in my review of
> v6, it's not safe. Please use mtd_device_unregister() + nand_cleanup()
> instead, and check the return code of mtd_device_unregister().

Whoops missed that one. Will send v8.

--
Stefan

> 
> With this addressed
> 
> Reviewed-by: Boris Brezillon <boris.brezillon@...tlin.com>
> 
>> +
>> +	clk_disable_unprepare(ctrl->clk);
>> +
>> +	return 0;
>> +}
>> +