linux-kernel - RE: [PATCH 4.4 16/37] i2c: rcar: rework hw init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 25 Jun 2018 10:05:11 +0000
From:   Fabrizio Castro <fabrizio.castro@...renesas.com>
To:     Wolfram Sang <wsa+renesas@...g-engineering.com>,
        Wolfram Sang <wsa@...-dreams.de>
CC:     "stable@...r.kernel.org" <stable@...r.kernel.org>,
        Chris Paterson <Chris.Paterson2@...esas.com>,
        Ben Hutchings <ben.hutchings@...ethink.co.uk>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 4.4 16/37] i2c: rcar: rework hw init

Hello Wolfram,

What do you think about this?

Thanks,
Fab

> -----Original Message-----
> From: stable-owner@...r.kernel.org [mailto:stable-owner@...r.kernel.org] On Behalf Of Ben Hutchings
> Sent: 18 June 2018 19:47
> To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>; linux-kernel@...r.kernel.org
> Cc: stable@...r.kernel.org; Wolfram Sang <wsa+renesas@...g-engineering.com>; Wolfram Sang <wsa@...-dreams.de>; Fabrizio
> Castro <fabrizio.castro@...renesas.com>; Chris Paterson <Chris.Paterson2@...esas.com>
> Subject: Re: [PATCH 4.4 16/37] i2c: rcar: rework hw init
>
> On Tue, 2018-06-05 at 19:01 +0200, Greg Kroah-Hartman wrote:
> > 4.4-stable review patch.  If anyone has any objections, please let me know.
> >
> > ------------------
> >
> > From: Wolfram Sang <wsa+renesas@...g-engineering.com>
> >
> > commit 2c78cdc1c06308a59d6ed4145cdba73fdeff8c0d upstream.
> >
> > We don't need to init HW before every transfer since we know the HW
> > state then. HW init at probe time is enough.
>
> This part got reverted upstream by:
>
> commit ae481cc139658e89eb3ea671dd00b67bd87f01a3
> Author: Wolfram Sang <wsa+renesas@...g-engineering.com>
> Date:   Tue Apr 18 20:38:35 2017 +0200
>
>     i2c: rcar: fix resume by always initializing registers before transfer
>
> so maybe that should go into stable (4.4 and 4.9 branches) too?
>
> Ben.
>
> > While here, add setting the
> > clock register which belongs to init HW. Also, set MDBS bit since not
> > setting it is prohibited according to the manual.
> [...]
>
> --
> Ben Hutchings, Software Developer                         Codethink Ltd
> https://www.codethink.co.uk/                 Dale House, 35 Dale Street
>                                      Manchester, M1 2HF, United Kingdom



Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.