linux-kernel - [PATCH] Regression fix for Chipidea USB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 25 Jun 2018 13:54:05 +0300
From:   mika.penttila@...tfour.com
To:     Peter.Chen@....com, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     Mika Penttilä <mika.penttila@...tfour.com>
Subject: [PATCH] Regression fix for Chipidea USB

From: Mika Penttilä <mika.penttila@...tfour.com>

I started to see usb failures on i.MX6, like "nonzero urb status received" after:

" commit 4e88d4c083016454f179686529ae65d70b933b58
 Author: Martin Blumenstingl <martin.blumenstingl@...glemail.com>
 Date:   Sat Mar 3 22:43:03 2018 +0100

     usb: add a flag to skip PHY initialization to struct usb_hcd"

The errors were related to some scpecific scenarios, like usb device reset, disappear etc.

The fix below worked for me.

--Mika


Signed-off-by: Mika Penttilä <mika.penttila@...tfour.com>

---
 drivers/usb/chipidea/host.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/usb/chipidea/host.c b/drivers/usb/chipidea/host.c
index af45aa32..c45d081 100644
--- a/drivers/usb/chipidea/host.c
+++ b/drivers/usb/chipidea/host.c
@@ -124,6 +124,9 @@ static int host_start(struct ci_hdrc *ci)
 
 	hcd->power_budget = ci->platdata->power_budget;
 	hcd->tpl_support = ci->platdata->tpl_support;
+
+	hcd->usb_phy = ci->usb_phy;
+
 	if (ci->phy || ci->usb_phy)
 		hcd->skip_phy_initialization = 1;
 
-- 
1.9.1