linux-kernel - Re: [PATCH] efi: Remove the declaration of efi_late

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 25 Jun 2018 08:02:01 +0200
From:   Ard Biesheuvel <ard.biesheuvel@...aro.org>
To:     Sai Praneeth Prakhya <sai.praneeth.prakhya@...el.com>
Cc:     linux-efi <linux-efi@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Lee Chun-Yi <jlee@...e.com>, Borislav Petkov <bp@...en8.de>,
        Dave Young <dyoung@...hat.com>,
        Bhupesh Sharma <bhsharma@...hat.com>,
        Ricardo Neri <ricardo.neri@...el.com>,
        Ravi Shankar <ravi.v.shankar@...el.com>,
        Matt Fleming <matt@...eblueprint.co.uk>
Subject: Re: [PATCH] efi: Remove the declaration of efi_late_init() as the
 function is unused

On 25 June 2018 at 03:47, Sai Praneeth Prakhya
<sai.praneeth.prakhya@...el.com> wrote:
> From: Sai Praneeth <sai.praneeth.prakhya@...el.com>
>
> Commit 7b0a911478c74 (efi/x86: Move the EFI BGRT init code to early
> init code), removed the implementation and all the references to
> efi_late_init() but the function is still declared at
> include/linux/efi.h. Hence, remove the unnecessary declaration.
>
> Signed-off-by: Sai Praneeth Prakhya <sai.praneeth.prakhya@...el.com>
> Cc: Lee Chun-Yi <jlee@...e.com>
> Cc: Borislav Petkov <bp@...en8.de>
> Cc: Dave Young <dyoung@...hat.com>
> Cc: Bhupesh Sharma <bhsharma@...hat.com>
> Cc: Ricardo Neri <ricardo.neri@...el.com>
> Cc: Ravi Shankar <ravi.v.shankar@...el.com>
> Cc: Matt Fleming <matt@...eblueprint.co.uk>
> Cc: Ard Biesheuvel <ard.biesheuvel@...aro.org>

Thanks Sai

Queued in efi/next

> ---
>  include/linux/efi.h | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/include/linux/efi.h b/include/linux/efi.h
> index 56add823f190..ae47be636b98 100644
> --- a/include/linux/efi.h
> +++ b/include/linux/efi.h
> @@ -988,14 +988,12 @@ extern void efi_memmap_walk (efi_freemem_callback_t callback, void *arg);
>  extern void efi_gettimeofday (struct timespec64 *ts);
>  extern void efi_enter_virtual_mode (void);     /* switch EFI to virtual mode, if possible */
>  #ifdef CONFIG_X86
> -extern void efi_late_init(void);
>  extern void efi_free_boot_services(void);
>  extern efi_status_t efi_query_variable_store(u32 attributes,
>                                              unsigned long size,
>                                              bool nonblocking);
>  extern void efi_find_mirror(void);
>  #else
> -static inline void efi_late_init(void) {}
>  static inline void efi_free_boot_services(void) {}
>
>  static inline efi_status_t efi_query_variable_store(u32 attributes,
> --
> 2.7.4
>