linux-kernel - Re: [PATCH] scsi: lpfc: use monotonic timestamps for statistics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 26 Jun 2018 12:00:54 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     James Smart <james.smart@...adcom.com>,
        Dick Kennedy <dick.kennedy@...adcom.com>,
        "James E.J. Bottomley" <jejb@...ux.vnet.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        y2038@...ts.linaro.org, Hannes Reinecke <hare@...e.com>,
        Johannes Thumshirn <jthumshirn@...e.de>,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: lpfc: use monotonic timestamps for statistics


Arnd,

> The get_seconds() function suffers from a possible overflow in 2038 or
> 2106, as well as jitter due to settimeofday or leap second updates,
> and is deprecated.
>
> As we are interested in elapsed time only, using ktime_get_seconds()
> to read the CLOCK_MONOTONIC timebase is ideal here. This also lets us
> remove the hack that tries to deal with get_seconds() going slightly
> backwards, which cannot happen with montonic timestamps.

Applied to 4.19/scsi-queue. Thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering