linux-kernel - Re: [PATCH v3 5/8] staging: rtl8192u: Use %s and __func__ instead of hardcoded string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 27 Jun 2018 21:22:50 +0100
From:   John Whitmore <arigead@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     John Whitmore <johnfwhitmore@...il.com>,
        linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org
Subject: Re: [PATCH v3 5/8] staging: rtl8192u: Use %s and __func__ instead of
 hardcoded string - Style

On Tue, Jun 26, 2018 at 11:56:24AM +0800, Greg KH wrote:
> On Sun, Jun 24, 2018 at 04:34:51PM +0100, John Whitmore wrote:
> > Changed a number of hard coded function names to use %s and __func__
> > 
> > Mailing list response suggest that there is a better method for debugging
> > using netdev_dbg(). I can't argue with that, but for the moment this change
> > will clear the checkpatch.pl Warning.
> > 
> > Signed-off-by: John Whitmore <johnfwhitmore@...il.com>
> > ---
> >  drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 12 ++++++------
> >  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> Did not apply :(

No worries, can I just ask is that because it should be changed to use
netdev_dbg as was suggested? And should that be across the whole file?