linux-kernel - Re: [PATCH] mmc: dw_mmc should depend on COMMON

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 2 Jul 2018 15:32:34 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Ulf Hansson <ulf.hansson@...aro.org>
Cc:     Corentin Labbe <clabbe@...libre.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux MMC List <linux-mmc@...r.kernel.org>
Subject: Re: [PATCH] mmc: dw_mmc should depend on COMMON_CLK

Hi Ulf,

On Mon, Jul 2, 2018 at 3:18 PM Ulf Hansson <ulf.hansson@...aro.org> wrote:
> On 6 June 2018 at 20:43, Corentin Labbe <clabbe@...libre.com> wrote:
> > This patch fix the following build failure on m68k:
> > ERROR: "clk_set_rate" [drivers/mmc/host/dw_mmc.ko] undefined!
> >
> > Signed-off-by: Corentin Labbe <clabbe@...libre.com>
>
> Thanks, applied for next!

Please drop this patch, I posted proper fixes for this general issue in series
"[PATCH 0/3] Legacy clock drivers: Normalize clk API"
(https://lkml.org/lkml/2018/6/11/122).

All fixes above are already in next-20180702.
Thanks!

> > ---
> >  drivers/mmc/host/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> > index 0581c199c996..77d6ba090436 100644
> > --- a/drivers/mmc/host/Kconfig
> > +++ b/drivers/mmc/host/Kconfig
> > @@ -666,7 +666,7 @@ config MMC_CAVIUM_THUNDERX
> >
> >  config MMC_DW
> >         tristate "Synopsys DesignWare Memory Card Interface"
> > -       depends on ARC || ARM || ARM64 || MIPS || COMPILE_TEST
> > +       depends on COMMON_CLK && (ARC || ARM || ARM64 || MIPS || COMPILE_TEST)
> >         help
> >           This selects support for the Synopsys DesignWare Mobile Storage IP
> >           block, this provides host support for SD and MMC interfaces, in both

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds