linux-kernel - RE: [PATCH] platform/x86: dell-smbios-wmi: make function dell_smbios_wmi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 2 Jul 2018 13:33:29 +0000
From:   <Mario.Limonciello@...l.com>
To:     <colin.king@...onical.com>, <dvhart@...radead.org>,
        <andy@...radead.org>, <platform-driver-x86@...r.kernel.org>
CC:     <kernel-janitors@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] platform/x86: dell-smbios-wmi: make function
 dell_smbios_wmi_call static



> -----Original Message-----
> From: Colin King [mailto:colin.king@...onical.com]
> Sent: Saturday, June 30, 2018 7:10 AM
> To: Limonciello, Mario; Darren Hart; Andy Shevchenko; platform-driver-
> x86@...r.kernel.org
> Cc: kernel-janitors@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: [PATCH] platform/x86: dell-smbios-wmi: make function
> dell_smbios_wmi_call static
> 
> From: Colin Ian King <colin.king@...onical.com>
> 
> The function dell_smbios_wmi_call is local to the source and does not
> need to be in global scope, so make it static.
> 
> Cleans up sparse warning:
> symbol 'dell_smbios_wmi_call' was not declared. Should it be static?
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Same vain as the other one of these, makes sense to me.

Acked-by: Mario Limonciello <mario.limonciello@...l.com>

> ---
>  drivers/platform/x86/dell-smbios-wmi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/dell-smbios-wmi.c b/drivers/platform/x86/dell-
> smbios-wmi.c
> index fbefedb1c172..88afe5651d24 100644
> --- a/drivers/platform/x86/dell-smbios-wmi.c
> +++ b/drivers/platform/x86/dell-smbios-wmi.c
> @@ -82,7 +82,7 @@ static int run_smbios_call(struct wmi_device *wdev)
>  	return 0;
>  }
> 
> -int dell_smbios_wmi_call(struct calling_interface_buffer *buffer)
> +static int dell_smbios_wmi_call(struct calling_interface_buffer *buffer)
>  {
>  	struct wmi_smbios_priv *priv;
>  	size_t difference;
> --
> 2.17.1