linux-kernel - Re: [PATCH] bindings: add clocks optional binding for imx gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 2 Jul 2018 10:54:06 -0300
From:   Fabio Estevam <festevam@...il.com>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     Anson Huang <Anson.Huang@....com>,
        Fabio Estevam <fabio.estevam@....com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        NXP Linux Team <Linux-imx@....com>
Subject: Re: [PATCH] bindings: add clocks optional binding for imx gpio

On Mon, Jul 2, 2018 at 10:45 AM, Linus Walleij <linus.walleij@...aro.org> wrote:
> On Fri, Jun 29, 2018 at 5:34 AM Anson Huang <Anson.Huang@....com> wrote:
>
>> Some i.MX SoCs have GPIO clock gate in CCM, accessing
>> GPIO registers needs to enable GPIO clock gate first,
>> i.MX GPIO driver will enable clock gate if there is
>> clock property in GPIO node of dtb, add optional property
>> to i.MX GPIO binding doc.
>>
>> Signed-off-by: Anson Huang <Anson.Huang@....com>
>
> Make sense since the gpio-mxc driver already supports this :)
>
>> +Optional properties:
>> +- clocks: the clocks used by gpio bank
>
> Should the text be "the clock for clocking the GPIO silicon"
> I guess that is what it is. And singularis?
>
> Does it hurt to give the clock a name? Like the common
> "pclk" for peripheral clock or something similar that other
> i.MX silicon uses?
>
> Fabio: can we have your ACK on this too.

In case a respin will be made for this one I would suggest to add the
name of the SoCs that need to pass the GPIO clock like imx6ul, imx6sll
in the commit log.

Reviewed-by: Fabio Estevam <fabio.estevam@....com>