linux-kernel - Re: [PATCH] leds: max8997: use mode when calling max8997_led_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 2 Jul 2018 22:24:26 +0200
From:   Jacek Anaszewski <jacek.anaszewski@...il.com>
To:     Colin King <colin.king@...onical.com>, Pavel Machek <pavel@....cz>
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] leds: max8997: use mode when calling max8997_led_set_mode

Hi Colin,

Thank you for the patch.

On 07/02/2018 06:50 PM, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> Variable mode is assigned to pdata->led_pdata->mode[led->id] and yet
> is not being used when calling function max8997_led_set_mode. Fix
> this by using mode when calling max8997_led_set_mode.
> 
> Cleans up clang warning:
> warning: variable 'mode' set but not used [-Wunused-but-set-variable]
> 
> Fixes: 8584cb82f151 ("leds: Add suuport for MAX8997-LED driver")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>   drivers/leds/leds-max8997.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/leds/leds-max8997.c b/drivers/leds/leds-max8997.c
> index 4edf74f1d6d4..8c019c28f9f5 100644
> --- a/drivers/leds/leds-max8997.c
> +++ b/drivers/leds/leds-max8997.c
> @@ -268,7 +268,7 @@ static int max8997_led_probe(struct platform_device *pdev)
>   		mode = pdata->led_pdata->mode[led->id];
>   		brightness = pdata->led_pdata->brightness[led->id];
>   
> -		max8997_led_set_mode(led, pdata->led_pdata->mode[led->id]);
> +		max8997_led_set_mode(led, mode);
>   
>   		if (brightness > led->cdev.max_brightness)
>   			brightness = led->cdev.max_brightness;
> 

Applied.

-- 
Best regards,
Jacek Anaszewski