linux-kernel - RE: [[LINUX PATCH v10] 4/4] mtd: rawnand: pl353: Add basic driver for arm pl353 smc nand interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 3 Jul 2018 04:19:00 +0000
From:   Naga Sureshkumar Relli <nagasure@...inx.com>
To:     Linus Walleij <linus.walleij@...aro.org>
CC:     Boris Brezillon <boris.brezillon@...tlin.com>,
        Richard Weinberger <richard@....at>,
        David Woodhouse <dwmw2@...radead.org>,
        Brian Norris <computersforpeace@...il.com>,
        Mark Vasut <marek.vasut@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Markus Mayer <mmayer@...adcom.com>,
        Roger Quadros <rogerq@...com>,
        Ladislav Michl <ladis@...ux-mips.org>,
        "ada@...rsis.com" <ada@...rsis.com>,
        "honghui.zhang@...iatek.com" <honghui.zhang@...iatek.com>,
        Miquèl Raynal <miquel.raynal@...tlin.com>,
        "linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "nagasureshkumarrelli@...il.com" <nagasureshkumarrelli@...il.com>,
        Michal Simek <michals@...inx.com>
Subject: RE: [[LINUX PATCH v10] 4/4] mtd: rawnand: pl353: Add basic driver for
 arm pl353 smc nand interface

Hi Linus,

> -----Original Message-----
> From: Linus Walleij [mailto:linus.walleij@...aro.org]
> Sent: Monday, July 2, 2018 7:18 PM
> To: Naga Sureshkumar Relli <nagasure@...inx.com>
> Cc: Boris Brezillon <boris.brezillon@...tlin.com>; Richard Weinberger <richard@....at>;
> David Woodhouse <dwmw2@...radead.org>; Brian Norris
> <computersforpeace@...il.com>; Mark Vasut <marek.vasut@...il.com>; Florian Fainelli
> <f.fainelli@...il.com>; Markus Mayer <mmayer@...adcom.com>; Roger Quadros
> <rogerq@...com>; Ladislav Michl <ladis@...ux-mips.org>; ada@...rsis.com;
> honghui.zhang@...iatek.com; Miquèl Raynal <miquel.raynal@...tlin.com>; linux-
> mtd@...ts.infradead.org; linux-kernel@...r.kernel.org; nagasureshkumarrelli@...il.com;
> Michal Simek <michals@...inx.com>
> Subject: Re: [[LINUX PATCH v10] 4/4] mtd: rawnand: pl353: Add basic driver for arm
> pl353 smc nand interface
> 
> On Fri, Jun 29, 2018 at 6:15 AM Naga Sureshkumar Relli <nagasure@...inx.com> wrote:
> > > On Thu, Jun 28, 2018 at 2:13 PM Naga Sureshkumar Relli <nagasure@...inx.com>
> wrote:
> > >
> > >
> > > > > This driver has the same problem as the other patches:
> > > > > use the ARM_AMBA primecell magic numbers detection, and the PrimeCell bus.
> > > >
> > > > Here the child is NAND controller and the parent is PL353 SMC, so
> > > > do we need to update this also as AMBA driver?
> > >
> > > No, sorry. The parent is spawning another device and you should
> > > indeed use a platform device for that.
> > >
> > Ok, you mean platform driver model is sufficient for both pl353-smc.c and pl353_nand.c
> drivers?
> > Or AMBA model is for pl353-smc and platform driver model is for pl353-nand?
> 
> The latter, AMBA primecell bus for pl353-smc and platform device for the nand subdevice.
> 
> Platform device is for anything that cannot be autodetected with e.g.
> magic hardare numbers, and the first device can be autodetected as a prime cell but not the
> subdevice.
Thanks for your inputs, I already started updating this.
I will send v11.

Thanks,
Naga Sureshkumar Relli.
> 
> Yours,
> Linus Walleij