linux-kernel - [PATCHv2 2/2] dmaengine: imx-sdma: request firmware with FW_OPT_NO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed,  4 Jul 2018 18:05:00 +0200
From:   Sebastian Reichel <sebastian.reichel@...labora.co.uk>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Kees Cook <keescook@...omium.org>,
        Hans de Goede <hdegoede@...hat.com>
Cc:     andresx7@...il.com, torvalds@...ux-foundation.org,
        "Luis R. Rodriguez" <mcgrof@...nel.org>,
        Dan Williams <dan.j.williams@...el.com>,
        Vinod Koul <vkoul@...nel.org>, dmaengine@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Rafał Miłecki <rafal@...ecki.pl>,
        kernel@...labora.com,
        Sebastian Reichel <sebastian.reichel@...labora.co.uk>
Subject: [PATCHv2 2/2] dmaengine: imx-sdma: request firmware with FW_OPT_NO_WARN

Request firmware with FW_OPT_NO_WARN. The driver works without the
firmware by using the one supplied in ROM. There is already an info
message, that informs about this.

Signed-off-by: Sebastian Reichel <sebastian.reichel@...labora.co.uk>
---
 drivers/dma/imx-sdma.c | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
index f077992635c2..68f7e5a2092f 100644
--- a/drivers/dma/imx-sdma.c
+++ b/drivers/dma/imx-sdma.c
@@ -1599,13 +1599,9 @@ static int sdma_event_remap(struct sdma_engine *sdma)
 static int sdma_get_firmware(struct sdma_engine *sdma,
 		const char *fw_name)
 {
-	int ret;
-
-	ret = request_firmware_nowait(THIS_MODULE,
-			FW_ACTION_HOTPLUG, fw_name, sdma->dev,
-			GFP_KERNEL, sdma, sdma_load_firmware);
-
-	return ret;
+	return request_firmware_nowait_nowarn(THIS_MODULE, FW_ACTION_HOTPLUG,
+					      fw_name, sdma->dev, GFP_KERNEL,
+					      sdma, sdma_load_firmware);
 }
 
 static int sdma_init(struct sdma_engine *sdma)
-- 
2.18.0