lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 4 Jul 2018 06:25:53 +0200 From: Borislav Petkov <bp@...en8.de> To: Thomas Gleixner <tglx@...utronix.de> Cc: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>, x86@...nel.org, platform-driver-x86@...r.kernel.org, dave.hansen@...el.com, sean.j.christopherson@...el.com, nhorman@...hat.com, npmccallum@...hat.com, linux-sgx@...r.kernel.org, Ingo Molnar <mingo@...hat.com>, "H. Peter Anvin" <hpa@...or.com>, "open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH v12 09/13] x86/sgx: EPC page allocation routines On Tue, Jul 03, 2018 at 10:41:14PM +0200, Thomas Gleixner wrote: > On Tue, 3 Jul 2018, Jarkko Sakkinen wrote: > > > > +#define SGX_NR_TO_SCAN 16 > > +#define SGX_NR_LOW_PAGES 32 > > +#define SGX_NR_HIGH_PAGES 64 > > + > > bool sgx_enabled __ro_after_init; > > EXPORT_SYMBOL(sgx_enabled); > > bool sgx_lc_enabled __ro_after_init; > > EXPORT_SYMBOL(sgx_lc_enabled); > > +LIST_HEAD(sgx_active_page_list); > > +EXPORT_SYMBOL(sgx_active_page_list); > > +DEFINE_SPINLOCK(sgx_active_page_list_lock); > > +EXPORT_SYMBOL(sgx_active_page_list_lock); > > Why is all of this exported. If done right then no call site has to fiddle > with the list and the lock at all. ... and also, why are the other exports not EXPORT_SYMBOL_GPL? -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.
Powered by blists - more mailing lists