linux-kernel - Re: [PATCH] x86/numa_emulation: Fix uniform size build failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 5 Jul 2018 19:55:40 -0700
From:   Dan Williams <dan.j.williams@...el.com>
To:     Ingo Molnar <mingo@...nel.org>
Cc:     David Rientjes <rientjes@...gle.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Wei Yang <richard.weiyang@...il.com>,
        kbuild test robot <lkp@...el.com>, X86 ML <x86@...nel.org>,
        Linux MM <linux-mm@...ck.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86/numa_emulation: Fix uniform size build failure

On Thu, Jul 5, 2018 at 1:24 AM, Ingo Molnar <mingo@...nel.org> wrote:
>
> * Dan Williams <dan.j.williams@...el.com> wrote:
>
>> The calculation of a uniform numa-node size attempted to perform
>> division with a 64-bit diviser leading to the following failure on
>> 32-bit:
>>
>>     arch/x86/mm/numa_emulation.o: In function `split_nodes_size_interleave_uniform':
>>     arch/x86/mm/numa_emulation.c:239: undefined reference to `__udivdi3'
>>
>> Convert the implementation to do the division in terms of pages and then
>> shift the result back to an absolute physical address.
>>
>> Fixes: 93e738834fcc ("x86/numa_emulation: Introduce uniform split capability")
>> Cc: David Rientjes <rientjes@...gle.com>
>> Cc: Thomas Gleixner <tglx@...utronix.de>
>> Cc: Wei Yang <richard.weiyang@...il.com>
>> Reported-by: kbuild test robot <lkp@...el.com>
>> Signed-off-by: Dan Williams <dan.j.williams@...el.com>
>
> I'm still getting this link failure on 32-bit kernels:
>
>  arch/x86/mm/numa_emulation.o: In function `split_nodes_size_interleave_uniform.constprop.1':
>  numa_emulation.c:(.init.text+0x669): undefined reference to `__udivdi3'
>  Makefile:1005: recipe for target 'vmlinux' failed
>
> config attached.
>
> These numa_emulation changes are a bit of a trainwreck - I'm removing both
> num_emulation commits from -tip for now, could you please resubmit a fixed/tested
> combo version?
>

So I squashed the fix and let the 0day robot chew on it all day with
no reports as of yet. I just recompiled it here and am not seeing the
link failure, can you send me the details of the kernel config + gcc
version that is failing?