lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Sat, 7 Jul 2018 16:05:18 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Tamir Suliman <tsuliman@...uxvaults.com>
Cc:     w.d.hubbs@...il.com, speakup@...ux-speakup.org,
        dhowells@...hat.com, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org, chris@...-brannons.com
Subject: Re: [PATCH 3/3] drivers/speakup: kobjects : Fixed Coding issues
 -Debugging

On Thu, Jul 05, 2018 at 02:12:20AM +0000, Tamir Suliman wrote:
> Updated printk() of i18n messages to include KERN_INFO facility level to improve debuggin.
> then later noticed that I forgot to add a space on printk.
> 
> Signed-off-by: Tamir Suliman <tsuliman@...uxvaults.com>
> ---
>  drivers/staging/speakup/kobjects.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/speakup/kobjects.c b/drivers/staging/speakup/kobjects.c
> index 7e79f99..af664f0 100644
> --- a/drivers/staging/speakup/kobjects.c
> +++ b/drivers/staging/speakup/kobjects.c
> @@ -740,7 +740,7 @@ static void report_msg_status(int reset, int received, int used,
>  			snprintf(buf + (len - 1), sizeof(buf) - (len - 1),
>  				 " with %d reject%s\n",
>  				 rejected, rejected > 1 ? "s" : "");
> -		printk(KERN_INFO "i18n messages rejected\n",buf);
> +		printk(KERN_INFO "i18n messages rejected\n", buf);
>  	}
>  }
>  
> -- 
> 1.8.3.1

Where are patches 1 and 2 of this series?

And the changelog text does not match what the text itself does, so I
can't take this as-is :(

greg k-h

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ