linux-kernel - Re: [PATCH net-next 3/6] net: mvneta: discriminate error cause for missed packet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 07 Jul 2018 11:09:00 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     gregory.clement@...tlin.com
Cc:     linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        thomas.petazzoni@...tlin.com, linux-arm-kernel@...ts.infradead.org,
        jason@...edaemon.net, andrew@...n.ch,
        sebastian.hesselbarth@...il.com, yelena@...vell.com,
        nadavh@...vell.com, mw@...ihalf.com, dima@...vell.com,
        antoine.tenart@...tlin.com, miquel.raynal@...tlin.com,
        maxime.chevallier@...tlin.com
Subject: Re: [PATCH net-next 3/6] net: mvneta: discriminate error cause for
 missed packet

From: Gregory CLEMENT <gregory.clement@...tlin.com>
Date: Fri,  6 Jul 2018 15:19:46 +0200

> @@ -609,6 +606,10 @@ struct mvneta_rx_queue {
>  
>  	/* Index of the next RX DMA descriptor to process */
>  	int next_desc_to_proc;
> +
> +	/* error counters */
> +	u32 skb_alloc_err;
> +	u32 refill_err;
>  };

These counters aren't exported anywhere, making them not so useful.

Either remove this stuff or add them to the driver's ethtool state.

Thank you.