linux-kernel - Re: [patch 4/7] x86/kvmclock: Cleanup the code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 9 Jul 2018 12:03:42 +0200 (CEST)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Peter Zijlstra <peterz@...radead.org>
cc:     LKML <linux-kernel@...r.kernel.org>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Radim Krcmar <rkrcmar@...hat.com>,
        Juergen Gross <jgross@...e.com>,
        Pavel Tatashin <pasha.tatashin@...cle.com>,
        steven.sistare@...cle.com, daniel.m.jordan@...cle.com,
        x86@...nel.org, kvm@...r.kernel.org
Subject: Re: [patch 4/7] x86/kvmclock: Cleanup the code

On Mon, 9 Jul 2018, Peter Zijlstra wrote:
> On Fri, Jul 06, 2018 at 06:13:11PM +0200, Thomas Gleixner wrote:
> > -	native_write_msr(msr_kvm_wall_clock, low, high);
> > +	wrmsrl(msr_kvm_wall_clock, slow_virt_to_phys(&wall_clock));
> 
> Does it matter that you went from an explicit native WRMSR instruction
> to a potentially paravirt MSR thing?

Ah crap, that wants to be native_wrmsrl()