linux-kernel - Re: [PATCH 1/8] usb: pd: include kernel.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 9 Jul 2018 11:58:02 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Heikki Krogerus <heikki.krogerus@...ux.intel.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Hans de Goede <hdegoede@...hat.com>, Jun Li <jun.li@....com>,
        Mats Karrman <mats.dev.list@...il.com>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/8] usb: pd: include kernel.h

On Wed, Jun 27, 2018 at 06:19:46PM +0300, Heikki Krogerus wrote:
> This makes life a bit easier for the drivers that include
> pd.h. All pd_header_*_le() inline functions defined in pd.h
> call le16_to_cpu(), and all *_LE() macros in pd.h call
> cpu_to_le16().
> 
> Signed-off-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
> ---
>  include/linux/usb/pd.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/linux/usb/pd.h b/include/linux/usb/pd.h
> index 09b570feb297..f2162e0fe531 100644
> --- a/include/linux/usb/pd.h
> +++ b/include/linux/usb/pd.h
> @@ -15,6 +15,7 @@
>  #ifndef __LINUX_USB_PD_H
>  #define __LINUX_USB_PD_H
>  
> +#include <linux/kernel.h>

What is more appropriate ? This or asm/byteorder.h ?

Guenter

>  #include <linux/types.h>
>  #include <linux/usb/typec.h>
>  
> -- 
> 2.18.0
>