linux-kernel - Re: [PATCH 1/3] random: Remove unnecessary cast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 9 Jul 2018 22:06:13 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     "Tobin C. Harding" <me@...in.cc>
Cc:     Theodore Ts'o <tytso@....edu>, Petr Mladek <pmladek@...e.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Randy Dunlap <rdunlap@...radead.org>,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        Arnd Bergmann <arnd@...db.de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] random: Remove unnecessary cast

On Tue, 10 Jul 2018 10:25:17 +1000
"Tobin C. Harding" <me@...in.cc> wrote:

> Currently we are casting an argument to the macro min_t().  This is
> unnecessary since the macro already includes a cast.
> 
> Remove unnecessary cast from argument to macro min_t()
> 
> Signed-off-by: Tobin C. Harding <me@...in.cc>

Reviewed-by: Steven Rostedt (VMware) <rostedt@...dmis.org>

-- Steve

> ---
>  drivers/char/random.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/char/random.c b/drivers/char/random.c
> index d686aa2a129b..03bd13876901 100644
> --- a/drivers/char/random.c
> +++ b/drivers/char/random.c
> @@ -1736,7 +1736,7 @@ int __must_check get_random_bytes_arch(void *buf, int nbytes)
>  	trace_get_random_bytes_arch(left, _RET_IP_);
>  	while (left) {
>  		unsigned long v;
> -		int chunk = min_t(int, left, (int)sizeof(unsigned long));
> +		int chunk = min_t(int, left, sizeof(unsigned long));
>  
>  		if (!arch_get_random_long(&v))
>  			break;