linux-kernel - Re: [PATCH] vsprintf: fix build warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 9 Jul 2018 22:27:25 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     "Tobin C. Harding" <me@...in.cc>
Cc:     Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        Arnd Bergmann <arnd@...db.de>, Petr Mladek <pmladek@...e.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Theodore Ts'o <tytso@....edu>, linux-kernel@...r.kernel.org,
        kernelnewbies@...nelnewbies.org
Subject: Re: [PATCH] vsprintf: fix build warning

On Tue, 10 Jul 2018 09:42:03 +1000
"Tobin C. Harding" <me@...in.cc> wrote:

> Steve if you do not rebase your next branch and the branch ends up
> containing fixes to patches like the above doesn't this mean that when
> you do a pull request to Linus the branch you are asking to be pulled
> will be too 'dirty' i.e. I thought that the pull request should be like
> a patch set and only contain the 'final product' not every change that
> was made during development?

Nope, once I push to next, my branch is ready to be worked against.
Sha1 and all. Rebasing will break that. I also have a full test suite
that all my code runs through and it must pass before sending to Linus
or linux-next.

> 
> I was under the impression that each maintainer constantly rebased their
> next branches and that was why one has to checkout the tagged linux-next

Some maintainers (Ingo being one) is very against any unnecessary
rebasing. This is because it can hide the history and development of
code. Linus doesn't like to see rebasing of public trees. Once you
rebase, you lose all the prior testing done on the previous code. It
also makes it difficult for anyone that is basing code off of it.

> each day instead of just pulling.  From information on the net somewhere
> I have been checking out linux-next using this shell function
> 
> checkout-next () {
> 	local branch='linux-next' 
> 
> 	git checkout master
> 	git remote update linux-next
> 	git branch -D $branch
> 	git checkout -b $branch $(git tag -l "next-*" | tail -1)
> }

I believe linux-next itself creates its master branch each time it
pulls in everyone's branches. It throws away the old one, and pulls in
all the new ones. This makes sense because otherwise the history will be
loaded with pulls from various branches. And yes, some branches will
rebase. If just one branch rebases, then it would need to do this.

> 
> Also, when my leaks tree got included in linux-next I was told that it
> was ok to rebase and have since been rebasing mercilessly.

It's really a choice for the maintainer. I consider a branch that goes
into next as "tested". I wont rebase unless there is a nasty bug that I
don't want to go upstream. Or a compiler failure. Warnings don't bother
me. I've sometimes rebased to add Acked-by/Reviewed-by tags. But that's
because the code is identical to what was there before (I do git diffs
to confirm that).

Linus has yelled at people that have rebased just before sending a
pull request to him.

-- Steve