linux-kernel - Re: [PATCH v3 2/2] powerpc: Enable CPU_FTR_ASYM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 11 Jul 2018 16:32:30 +0800
From:   kbuild test robot <lkp@...el.com>
To:     "Gautham R. Shenoy" <ego@...ux.vnet.ibm.com>
Cc:     kbuild-all@...org, Michael Ellerman <mpe@...erman.id.au>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Michael Neuling <mikey@...ling.org>,
        Vaidyanathan Srinivasan <svaidy@...ux.vnet.ibm.com>,
        Akshay Adiga <akshay.adiga@...ux.vnet.ibm.com>,
        Shilpasri G Bhat <shilpa.bhat@...ux.vnet.ibm.com>,
        Oliver O'Halloran <oohall@...il.com>,
        Nicholas Piggin <npiggin@...il.com>,
        Murilo Opsfelder Araujo <muriloo@...ux.ibm.com>,
        linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
        "Gautham R. Shenoy" <ego@...ux.vnet.ibm.com>
Subject: Re: [PATCH v3 2/2] powerpc: Enable CPU_FTR_ASYM_SMT for interleaved
 big-cores

Hi Gautham,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on powerpc/next]
[also build test ERROR on v4.18-rc4 next-20180710]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Gautham-R-Shenoy/powerpc-Detect-the-presence-of-big-cores-via-ibm-thread-groups/20180706-174756
base:   https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
config: powerpc-g5_defconfig (attached as .config)
compiler: powerpc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.2.0 make.cross ARCH=powerpc 

All errors (new ones prefixed by >>):

   In file included from include/linux/static_key.h:1:0,
                    from include/linux/context_tracking_state.h:6,
                    from include/linux/vtime.h:5,
                    from include/linux/hardirq.h:8,
                    from include/linux/interrupt.h:11,
                    from include/linux/serial_core.h:25,
                    from include/linux/serial_8250.h:14,
                    from arch/powerpc/kernel/setup-common.c:33:
   arch/powerpc/kernel/setup-common.c: In function 'smp_setup_cpu_maps':
>> arch/powerpc/kernel/setup-common.c:777:25: error: 'cpu_feature_keys' undeclared (first use in this function); did you mean 'setup_feature_keys'?
      static_branch_enable(&cpu_feature_keys[key]);
                            ^
   include/linux/jump_label.h:434:55: note: in definition of macro 'static_branch_enable'
    #define static_branch_enable(x)   static_key_enable(&(x)->key)
                                                          ^
   arch/powerpc/kernel/setup-common.c:777:25: note: each undeclared identifier is reported only once for each function it appears in
      static_branch_enable(&cpu_feature_keys[key]);
                            ^
   include/linux/jump_label.h:434:55: note: in definition of macro 'static_branch_enable'
    #define static_branch_enable(x)   static_key_enable(&(x)->key)
                                                          ^

vim +777 arch/powerpc/kernel/setup-common.c

   772	
   773		if (has_interleaved_big_cores) {
   774			int key = __builtin_ctzl(CPU_FTR_ASYM_SMT);
   775	
   776			cur_cpu_spec->cpu_features |= CPU_FTR_ASYM_SMT;
 > 777			static_branch_enable(&cpu_feature_keys[key]);
   778			pr_info("Detected interleaved big-cores\n");
   779		}
   780	
   781		/* Initialize CPU <=> thread mapping/
   782		 *
   783		 * WARNING: We assume that the number of threads is the same for
   784		 * every CPU in the system. If that is not the case, then some code
   785		 * here will have to be reworked
   786		 */
   787		cpu_init_thread_core_maps(nthreads);
   788	
   789		/* Now that possible cpus are set, set nr_cpu_ids for later use */
   790		setup_nr_cpu_ids();
   791	
   792		free_unused_pacas();
   793	}
   794	#endif /* CONFIG_SMP */
   795	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (19895 bytes)