lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 12 Jul 2018 17:40:15 +0200 From: Greg Kroah-Hartman <gregkh@...uxfoundation.org> To: Tycho Andersen <tycho@...ho.ws> Cc: Jiri Slaby <jslaby@...e.com>, linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org, "Serge E . Hallyn" <serge@...lyn.com> Subject: Re: [PATCH v4] uart: fix race between uart_put_char() and uart_shutdown() On Thu, Jul 12, 2018 at 09:08:22AM -0600, Tycho Andersen wrote: > On Thu, Jul 12, 2018 at 05:04:38PM +0200, Greg Kroah-Hartman wrote: > > On Wed, Jul 11, 2018 at 10:07:44AM -0600, Tycho Andersen wrote: > > > + if (uport) > > > + spin_lock_irqsave(&uport->lock, flags); > > > > That's the same thing as just calling uart_port_lock(), why aren't you > > doing that? > > Because the compiler can't seem to "see" through the macros/ref calls, > and I get the warning I mentioned here if I use them: > > https://lkml.org/lkml/2018/7/6/840 What horrible version of gcc are you using that give you that? Don't open-code things just because of a broken compiler. thanks, greg k-h
Powered by blists - more mailing lists