linux-kernel - Re: [PATCH 2/2] spi: Introduce new driver for Qualcomm QuadSPI controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 12 Jul 2018 13:16:16 -0700
From:   Doug Anderson <dianders@...omium.org>
To:     Girish Mahadevan <girishm@...eaurora.org>
Cc:     Mark Brown <broonie@...nel.org>,
        linux-spi <linux-spi@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Stephen Boyd <swboyd@...omium.org>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        Sagar Dharia <sdharia@...eaurora.org>,
        Karthikeyan Ramasubramanian <kramasub@...eaurora.org>,
        boris.brezillon@...tlin.com
Subject: Re: [PATCH 2/2] spi: Introduce new driver for Qualcomm QuadSPI controller

Hi,

On Thu, Jul 5, 2018 at 2:46 PM, Girish Mahadevan <girishm@...eaurora.org> wrote:
> New driver for Qualcomm QuadSPI(QSPI) controller that is used to
> communicate with slaves such flash memory devices. The QSPI controller
> can operate in 2 or 4 wire mode but only supports SPI Mode 0 and SPI
> Mode 3. The controller can also operate in Single or Dual data rate modes.
>
> Signed-off-by: Girish Mahadevan <girishm@...eaurora.org>
> ---
>  drivers/spi/Kconfig         |   7 +
>  drivers/spi/Makefile        |   1 +
>  drivers/spi/spi-qcom-qspi.c | 728 ++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 736 insertions(+)
>  create mode 100644 drivers/spi/spi-qcom-qspi.c
>
> diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
> index 97e1fa9..bc71cd3 100644
> --- a/drivers/spi/Kconfig
> +++ b/drivers/spi/Kconfig
> @@ -571,6 +571,13 @@ config SPI_QCOM_GENI
>           This driver can also be built as a module.  If so, the module
>           will be called spi-geni-qcom.
>
> +config SPI_QCOM_QSPI
> +       tristate "QTI QPSPI controller"
> +       depends on ARCH_QCOM
> +       help
> +         QSPI(Quad SPI) driver for Qualcomm QSPI controller.
> +
>  config SPI_QUP
>         tristate "Qualcomm SPI controller with QUP interface"
>         depends on ARCH_QCOM || (ARM && COMPILE_TEST)

I tried to apply your patch and `patch` complained that it was
malformed.  In fact it is.  The numbers above say that there should be
13 lines in the section above but you only have 12.  Did you manually
munge the patch after generating it?  Please be more careful.


-Doug