linux-kernel - Re: [PATCH] staging: gasket remove current_kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 13 Jul 2018 17:33:51 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Rob Springer <rspringer@...gle.com>,
        John Joseph <jnjoseph@...gle.com>,
        Ben Chan <benchan@...omium.org>, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org, Simon Que <sque@...omium.org>
Subject: Re: [PATCH] staging: gasket remove current_kernel_time usage

On Fri, Jul 13, 2018 at 05:06:37PM +0200, Arnd Bergmann wrote:
> A new user of the deprecated current_kernel_time() function has appeared
> here. This code won't work correct during leap seconds or a concurrent
> settimeofday() call, and it probably doesn't do what the author intended
> even for the normal case, as it passes a timeout in nanoseconds but
> reads the time using a jiffies-granularity accessor.
> 
> I'm changing it to ktime_get_ns() here, which simplifies the logic,
> and uses a high-res clocksource. This is a bit slower, but that
> probably doesn't matter in a busy-wait loop.
> 
> Note: it also doesn't matter in the current version, as there are no
> callers of this function.

Let's just rip the whole function out, I've been going through and
removing functions that no one calls and no one uses.  That would make
more sense here.  Want me to send a patch for that, or do you want to?

thanks,

greg k-h