linux-kernel - Re: [PATCH 1/3] dt-bindings: clk: g12a: New binding for Meson-G12A SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Sat, 14 Jul 2018 16:30:40 +0200
From:   Martin Blumenstingl <martin.blumenstingl@...glemail.com>
To:     jian.hu@...ogic.com
Cc:     jbrunet@...libre.com, Neil Armstrong <narmstrong@...libre.com>,
        qianggui.song@...ogic.com, devicetree@...r.kernel.org,
        sboyd@...nel.org, khilman@...libre.com, mturquette@...libre.com,
        yixun.lan@...ogic.com, linux-kernel@...r.kernel.org,
        bo.yang@...ogic.com, qiufang.dai@...ogic.com,
        linux-arm-kernel@...ts.infradead.org, carlo@...one.org,
        linux-amlogic@...ts.infradead.org, sunny.luo@...ogic.com,
        linux-clk@...r.kernel.org, xingyu.chen@...ogic.com
Subject: Re: [PATCH 1/3] dt-bindings: clk: g12a: New binding for Meson-G12A SoC

On Wed, Jul 11, 2018 at 3:06 PM Jian Hu <jian.hu@...ogic.com> wrote:
>
>
>
> On 2018/7/10 17:29, Jerome Brunet wrote:
> > On Mon, 2018-07-09 at 19:12 +0800, Jian Hu wrote:
> >> Add new binding for Meson-G12A SoC Everything-Else part
> >
> > nitpick: I would prefer if the words 'clock' and 'controller' was somewhere in
> > the description.
> >
> > Maybe "add new clock controller compatible for the EE domain of the g12a SoC" ?
>
> Patch 1 and 2 have squashed, the commit message focuse which one？
I would use the information from both commit messages (for example you
could use the what Jerome already suggested and extend it with "and
add a header file which contains preprocessor macros to identify the
clocks provided by this clock controller")


Regards
Martin