linux-kernel - Re: [PATCH 12/18] staging: gasket: annotate ioctl arg with _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 14 Jul 2018 09:44:50 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Todd Poynor <toddpoynor@...il.com>
Cc:     Rob Springer <rspringer@...gle.com>,
        John Joseph <jnjoseph@...gle.com>,
        Ben Chan <benchan@...omium.org>, devel@...verdev.osuosl.org,
        Zhongze Hu <frankhu@...omium.org>,
        linux-kernel@...r.kernel.org, Simon Que <sque@...omium.org>,
        Guenter Roeck <groeck@...omium.org>,
        Todd Poynor <toddpoynor@...gle.com>,
        Dmitry Torokhov <dtor@...omium.org>
Subject: Re: [PATCH 12/18] staging: gasket: annotate ioctl arg with __user

On Sat, Jul 14, 2018 at 12:12:38AM -0700, Todd Poynor wrote:

HTML email gets rejected by the mailing lists :(

Please fix your email client to not do that.

> On Fri, Jul 13, 2018 at 11:35 PM, Greg Kroah-Hartman <
> gregkh@...uxfoundation.org> wrote:
> 
>     On Fri, Jul 13, 2018 at 10:58:10PM -0700, Todd Poynor wrote:
>     > From: Todd Poynor <toddpoynor@...gle.com>
>     >
>     > For sparse checking.
>     >
>     > Reported-by: Dmitry Torokhov <dtor@...omium.org>
>     > Signed-off-by: Zhongze Hu <frankhu@...omium.org>
>     > Signed-off-by: Todd Poynor <toddpoynor@...gle.com>
>     > ---
> 
>     Are you sure this patch even applies?  What tree did you make it
>     against?
> 
> 
> I'm working in linux-next at tag next-20180713, which is also tagged master at
> this writing. 
> 
> I think I'm following http://www.kroah.com/log/linux/linux-staging-update.html,
> but if I'm off in the weeds do clue me in, thanks. 

That's something I wrote 9 years ago :)

Anyway, yes, linux-next is usually the right place to work off of, but
it lags my staging.git tree usually by at least a day, maybe two,
depending on when I push and when -next picks my tree up.  Also there is
the lag of the weekend when -next is not being generated.

Normally that is fine, except for when working on code that is "fast
moving".  This driver has had lots of submissions against it lately as
there are loads of "low hanging fruit" that people easily see to fix up.
Look at the mailing list archives for this week alone for all of those
patches.

When working on something that lots of other people are working on, pay
attention to the patches on the mailing list and work off of my
staging.git tree, usually the staging-next branch, but sometimes
staging-testing is needed if lots of patches are being sent rapidly.

>     I ask because this fragment:
>    
>     > @@ -12,6 +12,7 @@
>     >   * GNU General Public License for more details.
>     >   */
> 
>     is no longer in the tree.
> 
> 
> Sorry, which tree?  I've made sure my linux-next is up-to-date and I still see
> this code.

Look at my staging-next branch in staging.git.  It's long-gone :)

thanks,

greg k-h