linux-kernel - [PATCH] x86/pci: Some buggy virtual functions incorrectly report 1 for intx.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 16 Jul 2018 13:42:25 -0700
From:   Ashok Raj <ashok.raj@...el.com>
To:     Alex Williamson <alex.williamson@...hat.com>,
        iommu@...ts.linux-foundation.org
Cc:     Ashok Raj <ashok.raj@...el.com>, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org, Joerg Roedel <joro@...tes.org>,
        Bjorn Helgaas <helgaas@...nel.org>,
        Gage Eads <gage.eads@...el.com>
Subject: [PATCH] x86/pci: Some buggy virtual functions incorrectly report 1 for intx.

PCI_INTERRUPT_PIN should always read  0 for SRIOV Virtual Functions.

Some SRIOV devices have some bugs in RTL and VF's end up reading 1
instead of 0 for the PIN.

We could enforce it by default in vfio_pci_nointx.

Reported-by: Gage Eads <gage.eads@...el.com>
Tested-by: Gage Eads <gage.eads@...el.com>
Signed-off-by: Ashok Raj <ashok.raj@...el.com>
Cc: linux-kernel@...r.kernel.org
Cc: stable@...r.kernel.org
Cc: iommu@...ts.linux-foundation.org
Cc: Joerg Roedel <joro@...tes.org>
Cc: Bjorn Helgaas <helgaas@...nel.org>
Cc: Gage Eads <gage.eads@...el.com>
---
 drivers/vfio/pci/vfio_pci.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/vfio/pci/vfio_pci.c b/drivers/vfio/pci/vfio_pci.c
index b423a30..bc3f4fa 100644
--- a/drivers/vfio/pci/vfio_pci.c
+++ b/drivers/vfio/pci/vfio_pci.c
@@ -192,6 +192,13 @@ static void vfio_pci_disable(struct vfio_pci_device *vdev);
  */
 static bool vfio_pci_nointx(struct pci_dev *pdev)
 {
+	/*
+	 * Per PCI, no VF's should have INTx
+	 * Simply disable it here
+	 */
+	if (pdev->is_virtfn)
+		return true;
+
 	switch (pdev->vendor) {
 	case PCI_VENDOR_ID_INTEL:
 		switch (pdev->device) {
-- 
2.7.4