linux-kernel - Re: [PATCH 01/10] staging:rtl8192u: remove typedef of enumeration TR_SELECT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 16 Jul 2018 10:41:38 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     John Whitmore <johnfwhitmore@...il.com>
Cc:     linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org,
        kstewart@...uxfoundation.org, pombredanne@...b.com,
        tglx@...utronix.de
Subject: Re: [PATCH 01/10] staging:rtl8192u: remove typedef of enumeration
 TR_SELECT - Style

On Fri, Jul 13, 2018 at 09:12:38PM +0100, John Whitmore wrote:
> To clear a checkpatch issue removed the typedef of the enumeration TR_SELECT
> this should not impact runtime code as it's only a coding style change.
> 
> Signed-off-by: John Whitmore <johnfwhitmore@...il.com>
> ---
>  drivers/staging/rtl8192u/ieee80211/ieee80211.h      |  4 ++--
>  drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c | 10 +++++-----
>  drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h     |  4 ++--
>  drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c |  6 +++---
>  4 files changed, 12 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211.h b/drivers/staging/rtl8192u/ieee80211/ieee80211.h
> index 3b7968681f77..0fa55af7060a 100644
> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211.h
> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211.h
> @@ -2391,7 +2391,7 @@ int ieee80211_rx_DELBA(struct ieee80211_device *ieee, struct sk_buff *skb);
>  void TsInitAddBA(struct ieee80211_device *ieee, PTX_TS_RECORD pTS,
>  		 u8 Policy, u8 bOverwritePending);
>  void TsInitDelBA(struct ieee80211_device *ieee,
> -		 PTS_COMMON_INFO pTsCommonInfo, TR_SELECT TxRxSelect);
> +		 PTS_COMMON_INFO pTsCommonInfo, enum TR_SELECT TxRxSelect);
>  void BaSetupTimeOut(struct timer_list *t);
>  void TxBaInactTimeout(struct timer_list *t);
>  void RxBaInactTimeout(struct timer_list *t);
> @@ -2402,7 +2402,7 @@ bool GetTs(
>  	PTS_COMMON_INFO                 *ppTS,
>  	u8                              *Addr,
>  	u8                              TID,
> -	TR_SELECT                       TxRxSelect,  //Rx:1, Tx:0
> +	enum TR_SELECT                  TxRxSelect,  //Rx:1, Tx:0

This really should be "enum tr_select", right?  No ALL CAPS variable
types please.

thanks,

greg k-h