linux-kernel - Re: [PATCH] staging: comedi: comedi_fops: Shift assignment operator '=' to previous line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 16 Jul 2018 10:19:46 +0100
From:   Ian Abbott <abbotti@....co.uk>
To:     Nishad Kamdar <nishadkamdar@...il.com>,
        H Hartley Sweeten <hsweeten@...ionengravers.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: comedi: comedi_fops: Shift assignment operator
 '=' to previous line

On 14/07/18 16:44, Nishad Kamdar wrote:
> Shift '=' assignment operator to the end of previous
> line to conform to preferred kernel style line wrapping.
> Issue reported by checkpatch CHECK.
> 
> Signed-off-by: Nishad Kamdar <nishadkamdar@...il.com>
> ---
>   drivers/staging/comedi/comedi_fops.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c
> index 1f3b1106f478..e18b61cdbdeb 100644
> --- a/drivers/staging/comedi/comedi_fops.c
> +++ b/drivers/staging/comedi/comedi_fops.c
> @@ -79,8 +79,8 @@ MODULE_PARM_DESC(comedi_default_buf_size_kb,
>   		 "default asynchronous buffer size in KiB (default "
>   		 __MODULE_STRING(CONFIG_COMEDI_DEFAULT_BUF_SIZE_KB) ")");
>   
> -unsigned int comedi_default_buf_maxsize_kb
> -	= CONFIG_COMEDI_DEFAULT_BUF_MAXSIZE_KB;
> +unsigned int comedi_default_buf_maxsize_kb =
> +	CONFIG_COMEDI_DEFAULT_BUF_MAXSIZE_KB;
>   module_param(comedi_default_buf_maxsize_kb, uint, 0644);
>   MODULE_PARM_DESC(comedi_default_buf_maxsize_kb,
>   		 "default maximum size of asynchronous buffer in KiB (default "
> 

That looks fine, thanks!

Reviewed-by: Ian Abbott <abbotti@....co.uk>

-- 
-=( Ian Abbott <abbotti@....co.uk> || Web: www.mev.co.uk )=-
-=( MEV Ltd. is a company registered in England & Wales. )=-
-=( Registered number: 02862268.  Registered address:    )=-
-=( 15 West Park Road, Bramhall, STOCKPORT, SK7 3JZ, UK. )=-