linux-kernel - RE: [PATCH] gpio: mxc: add power management support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 16 Jul 2018 06:14:33 +0000
From:   Anson Huang <anson.huang@....com>
To:     Fabio Estevam <festevam@...il.com>
CC:     Linus Walleij <linus.walleij@...aro.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>
Subject: RE: [PATCH] gpio: mxc: add power management support

Hi, Fabio

Anson Huang
Best Regards!


> -----Original Message-----
> From: Fabio Estevam [mailto:festevam@...il.com]
> Sent: Sunday, July 15, 2018 12:13 AM
> To: Anson Huang <anson.huang@....com>
> Cc: Linus Walleij <linus.walleij@...aro.org>; open list:GPIO SUBSYSTEM
> <linux-gpio@...r.kernel.org>; linux-kernel <linux-kernel@...r.kernel.org>;
> dl-linux-imx <linux-imx@....com>
> Subject: Re: [PATCH] gpio: mxc: add power management support
> 
> Hi Anson,
> 
> On Fri, Jul 13, 2018 at 10:53 PM, Anson Huang <anson.huang@....com>
> wrote:
> 
> > Here are the details, i.MX7D LPSR mode and i.MX8QM/8QXP etc.'
> > suspend/resume may cause GPIO bank lose power, so need to
> > save/restore, for other i.MX SoCs, although no need to do
> > save/restore, but doing it is NOT harmful, so do you think we should add SoC
> type check here?
> 
> I think it would be safer to restrict the save/restore operations to mx7/mx8.
> 
> You can add a fsl,imx7d-gpio compatible entry in the driver.
> 
> Thanks
OK, since i.MX7D has same GPIO type as i.MX35, to make it simple, I just added
a flag to indicate whether it supports save/restore, only i.MX7D enables
the flag now, since other i.MX8 SoCs' dts is NOT upstreamed yet, so I did NOT add
support for i.MX8 SoCs, please help review V2 patch, thanks.

Anson.