linux-kernel - Re: PATCH scripts/kernel-doc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 18 Jul 2018 07:22:46 +0900
From:   Mauro Carvalho Chehab <mchehab+samsung@...nel.org>
To:     valdis.kletnieks@...edu
Cc:     Jonathan Corbet <corbet@....net>,
        Mauro Carvalho Chehab <mchehab@...pensource.com>,
        linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: PATCH scripts/kernel-doc

Em Tue, 17 Jul 2018 12:57:29 -0400
valdis.kletnieks@...edu escreveu:

> Fix a warning whinge from Perl introduced by "scripts: kernel-doc: parse next structs/unions"
> 
> Unescaped left brace in regex is deprecated here (and will be fatal in Perl 5.32), passed through in regex; marked by <-- HERE in m/({ <-- HERE [^\{\}]*})/ at ./scripts/kernel-doc line 1155.
> Unescaped left brace in regex is deprecated here (and will be fatal in Perl 5.32), passed through in regex; marked by <-- HERE in m/({ <-- HERE )/ at ./scripts/kernel-doc line 1179.
> 
> Signed-off-by: Valdis Kletnieks <valdis.kletnieks@...edu>


Reviewed-by: Mauro Carvalho Chehab <mchehab+samsung@...nel.org>


> ---
> diff --git a/scripts/kernel-doc b/scripts/kernel-doc
> index 0057d8eafcc1..31a34ced55a3 100755
> --- a/scripts/kernel-doc
> +++ b/scripts/kernel-doc
> @@ -1152,7 +1152,7 @@ sub dump_struct($$) {
>  	}
>  
>  	# Ignore other nested elements, like enums
> -	$members =~ s/({[^\{\}]*})//g;
> +	$members =~ s/(\{[^\{\}]*})//g;
>  
>  	create_parameterlist($members, ';', $file, $declaration_name);
>  	check_sections($file, $declaration_name, $decl_type, $sectcheck, $struct_actual);
> @@ -1176,7 +1176,7 @@ sub dump_struct($$) {
>  			$declaration .= "\t" x $level;
>  		}
>  		$declaration .= "\t" . $clause . "\n";
> -		$level++ if ($clause =~ m/({)/ && !($clause =~m/}/));
> +		$level++ if ($clause =~ m/(\{)/ && !($clause =~m/}/));
>  	}
>  	output_declaration($declaration_name,
>  			   'struct',
> 




Cheers,
Mauro